Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump knative.dev/serving from 0.37.1 to 0.39.0 in /extensions/knative/generator #5618

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 27, 2023

Bumps knative.dev/serving from 0.37.1 to 0.39.0.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

@dependabot dependabot bot requested review from manusa and oscerd as code owners November 27, 2023 23:31
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Nov 27, 2023
@dependabot dependabot bot requested a review from rohanKanojia as a code owner November 27, 2023 23:31
@dependabot dependabot bot added the go Pull requests that update Go code label Nov 27, 2023
@dependabot dependabot bot requested review from shawkins and sunix as code owners November 27, 2023 23:31
@rohanKanojia
Copy link
Member

go build is failing :

github.com/fabric8io/kubernetes-client/extensions/knative/generator/cmd/generate imports
	knative.dev/eventing/pkg/apis/sources/v1 imports
	knative.dev/pkg/resolver imports
	knative.dev/pkg/controller imports
	knative.dev/pkg/leaderelection imports
	k8s.io/client-go/kubernetes imports
	k8s.io/client-go/kubernetes/typed/resource/v1alpha1 imports
	k8s.io/api/resource/v1alpha1: no required module provides package k8s.io/api/resource/v1alpha1; to add it:
	go get k8s.io/api/resource/v1alpha1
make: *** [Makefile:27: gobuild] Error 1
Error: Process completed with exit code 2.

Bumps [knative.dev/serving](https://github.com/knative/serving) from 0.37.1 to 0.39.0.
- [Release notes](https://github.com/knative/serving/releases)
- [Commits](knative/serving@v0.37.1...v0.39.0)

---
updated-dependencies:
- dependency-name: knative.dev/serving
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/go_modules/extensions/knative/generator/knative.dev/serving-0.39.0 branch from e333a40 to 6c2a460 Compare December 19, 2023 05:43
…atest versions

+ Bump Knative eventing to v0.39.0
+ Bump Knative networking, pkg, caching apis to latest versions

Signed-off-by: Rohan Kumar <[email protected]>
@rohanKanojia
Copy link
Member

rohanKanojia commented Dec 22, 2023

This change also requires marcnuri/golang-1.20-java17 to golang 21

CGO_ENABLED=0 GO111MODULE=on GO15VENDOREXPERIMENT=1 go run -mod=vendor -a ./cmd/generate/generate.go > ../model/src/main/resources/schema/knative-schema.json
vendor/knative.dev/networking/pkg/apis/networking/v1alpha1/ingress_helpers.go:20:2: package slices is not in GOROOT (/usr/local/go/src/slices)
make: *** [Makefile:28: gobuild] Error 1
Error: Process completed with exit code 2.

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@@ -20,7 +20,7 @@ set -e
BASEDIR=$(dirname "$BASH_SOURCE")
ABSOLUTE_BASEDIR=$(realpath "$BASEDIR/..")

DOCKER_IMAGE_GOLANG=marcnuri/golang-1.20-java17
DOCKER_IMAGE_GOLANG=marcnuri/golang-1.21-java17
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rohanKanojia This should be updated for the rest of the models

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Umm, sorry I don't understand.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦 for some reason I read that this was in a knative subdirectory.
Please close the issue I created indicating that this is a global value.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@manusa manusa added this to the 6.10.0 milestone Dec 22, 2023
@manusa manusa merged commit 8f02355 into main Dec 22, 2023
17 of 19 checks passed
@manusa manusa deleted the dependabot/go_modules/extensions/knative/generator/knative.dev/serving-0.39.0 branch December 22, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants